Re: [PATCH] arm64: dts: qcom: Move board nodes to common DTSI

[Dmitry Baryshkov]

On Fri, Mar 27, 2026 at 06:16:59PM +0530, Gopikrishna Garmidi wrote:
> 
> 
> On 3/26/2026 7:55 PM, Krzysztof Kozlowski wrote:
> > On 26/03/2026 15:21, Gopikrishna Garmidi wrote:
> > > The display, peripherals (touchpad/touchscreen/keypad), usb and their
> > > dependent device nodes are common to both Glymur and Mahua CRDs,
> > > so move them from glymur-crd.dts to glymur-crd.dtsi to enable code
> > > reuse.
> > > 
> > 
> > Same questions as for earlier tries (why this has to be repeated?), e.g.
> > x1-crd: Please describe here what is the actual common hardware. In
> > terms of physical hardware, not what you want to share.
> > 
> 
> Hi krzysztof,
> 
> Thanks for the review,
> 
> Will update the commit message in the next re-spin.

Before you respin, you can actually respond to the question. Do Glymur
and Mahua CRD actually share those devices (in case of USB that would
mean having the same baseboard with different SoCs being wired) or is it
just "oh, this looks similar enough, let's create a common file".

-- 
With best wishes
Dmitry