Re: [PATCH v3 3/7] fs,x86/resctrl: Add architecture hooks for every mount/unmount

[Chen, Yu C]

Hi Tony,

On 3/28/2026 7:02 AM, Tony Luck wrote:

> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index e3cfa0c10e92..6f322818a9e6 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -234,14 +234,18 @@ void rdt_domain_reconfigure_cdp(struct rdt_resource *r);
>   void resctrl_arch_mbm_cntr_assign_set_one(struct rdt_resource *r);
>   
>   #ifdef CONFIG_X86_CPU_RESCTRL_INTEL_AET
> -bool intel_aet_get_events(void);
> +bool intel_aet_pre_mount(void);
> +void intel_aet_mount_result(int ret);
> +void intel_aet_unmount(void);
>   void __exit intel_aet_exit(void);
>   int intel_aet_read_event(int domid, u32 rmid, void *arch_priv, u64 *val);
>   void intel_aet_mon_domain_setup(int cpu, int id, struct rdt_resource *r,
>   				struct list_head *add_pos);
>   bool intel_handle_aet_option(bool force_off, char *tok);
>   #else
> -static inline bool intel_aet_get_events(void) { return false; }

The declaration of intel_aet_get_events() was removed,
and the function definition still remains in intel_aet.c.
Not sure if this will trigger a warning like
"no user for intel_aet_get_events". Since intel_aet_get_events() is
renamed to static get_events() in a subsequent patch,
perhaps we can mark intel_aet_get_events() as static in
this patch too?

thanks,
Chenyu