Re: [PATCH v4 3/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU

[cristian_ci]

On Sunday, March 29th, 2026 at 12:12, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx> wrote:

> On Sat, Mar 28, 2026 at 05:30:53PM +0000, cristian_ci wrote:
> > On Friday, March 27th, 2026 at 23:57, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx> wrote:
> >
> > > On Fri, Mar 27, 2026 at 03:30:49PM +0100, Cristian Cozzolino via B4 Relay wrote:
> > > > From: Cristian Cozzolino <cristian_ci@xxxxxxxxxxxxxx>
> > > >
> > > > Add the description for the display panel found on this phone.
> > > > And with this done we can also enable the GPU and set the zap shader
> > > > firmware path.
> > > >
> > > > Signed-off-by: Cristian Cozzolino <cristian_ci@xxxxxxxxxxxxxx>
> > > > ---
> > > >  .../arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts | 73 ++++++++++++++++++++++
> > > >  1 file changed, 73 insertions(+)
> > > >
> > >
> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> >
> > I wonder if I should, instead, edit the compatible property by adding a
> > second string (for the fallback), like this:
> >
> > compatible = "flipkart,rimob-panel-nt35532-cs", "novatek,nt35532";
> >
> > and, therefore, add "novatek,nt35532" string also to (patch 1/6)'s
> > bindings example. Let me know what you think.
> 
> What would it mean? I think we usually don't include the IC into the
> compat list for the panel, but feel free to prove me wrong.

I've noticed use of that in this [1] patch series but I don't know why IC 
string is used there (in the example) if the specific panel string (the 
first one) is already defined in the panel driver.

[1] https://lore.kernel.org/linux-arm-msm/20251001135914.13754-2-caojunjie650@xxxxxxxxx/

Best Regards,

Cristian.

> --
> With best wishes
> Dmitry
>