Re: [PATCH 3/4] hwmon: (pxe1610) Check return value of page-select write in probe

From: Guenter Roeck

Date: Sun Mar 29 2026 - 15:13:11 EST


On Sun, Mar 29, 2026 at 05:09:48PM +0000, Pradhan, Sanman wrote:
> From: Sanman Pradhan <psanman@xxxxxxxxxxx>
>
> pxe1610_probe() writes PMBUS_PAGE to select page 0 but does not check
> the return value. If the write fails, subsequent register reads operate
> on an indeterminate page, leading to silent misconfiguration.
>
> Check the return value and propagate the error using dev_err_probe(),
> which also handles -EPROBE_DEFER correctly without log spam.
>
> Fixes: 28ccdfd11344 ("hwmon: (pmbus) Add Infineon PXE1610 VR driver")
> Signed-off-by: Sanman Pradhan <psanman@xxxxxxxxxxx>

Applied, after fixing the "Fixes" SHA.

Thanks,
Guenter