Re: [PATCH] staging: rtl8723bs: rename variables to snake_case

[Ethan Tidmore]

On Fri Mar 27, 2026 at 3:36 PM CDT, david wrote:
> From: David Holland <david@xxxxxxxxxxxxxxxxxx>
>
> The Linux kernel coding style guidelines prohibit the use of CamelCase
> variable names. All variables should be snakecase.
>
> Rename the 'ChipVersion' parameter to 'chip_version' and the
> 'AutoLoadFail' parameter to 'auto_load_fail' in hal_com.c to adhere to
> the standard snakecase naming convention.
>
> Signed-off-by: David Holland <david@xxxxxxxxxxxxxxxxxx>
> ---

...


>  
> @@ -86,7 +86,7 @@ void dump_chip_info(struct hal_version	ChipVersion)
>   *					BIT[6:0] Channel Plan
>   *sw_channel_plan		channel plan from SW (registry/module param)
>   *def_channel_plan	channel plan used when HW/SW both invalid
> - *AutoLoadFail		efuse autoload fail or not
> + *auto_load_fail		efuse autoload fail or not

I think the whitespace here was intentional (although I can't tell why
they did it like this), originally the comments starting with channel and
efuse lined up and this changes it.

Thanks,

ET