Re: [PATCH v4] Bluetooth: hci_qca: Convert timeout from jiffies to ms

[Shuai Zhang]

Hi Luiz

On 3/28/2026 1:53 AM, Luiz Augusto von Dentz wrote:
> Hi Shuai,
>
> On Fri, Mar 27, 2026 at 4:30 AM Shuai Zhang
> <shuai.zhang@xxxxxxxxxxxxxxxx> wrote:
> > From: Shuai Zhang <quic_shuaz@xxxxxxxxxxx>
> >
> > Since the timer uses jiffies as its unit rather than ms, the timeout value
> > must be converted from ms to jiffies when configuring the timer. Otherwise,
> > the intended 8s timeout is incorrectly set to approximately 33s.
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: d841502c79e3 ("Bluetooth: hci_qca: Collect controller memory dump during SSR")
> > Signed-off-by: Shuai Zhang <quic_shuaz@xxxxxxxxxxx>
> > Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
> > Acked-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> > ---
> > Changes v4:
> > - add review-by signoff
> > - Link to v3
> >    https://lore.kernel.org/all/20251107033924.3707495-1-quic_shuaz@xxxxxxxxxxx/
> >
> > Changes v3:
> > - add Fixes tag
> > - Link to v2
> >    https://lore.kernel.org/all/20251106140103.1406081-1-quic_shuaz@xxxxxxxxxxx/
> >
> > Changes v2:
> > - Split timeout conversion into a separate patch.
> > - Clarified commit messages and added test case description.
> > - Link to v1
> >    https://lore.kernel.org/all/20251104112601.2670019-1-quic_shuaz@xxxxxxxxxxx/
> > ---
> >
> >   drivers/bluetooth/hci_qca.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> > index 228a754a9..d66af13ab 100644
> > --- a/drivers/bluetooth/hci_qca.c
> > +++ b/drivers/bluetooth/hci_qca.c
> > @@ -1607,7 +1607,7 @@ static void qca_wait_for_dump_collection(struct hci_dev *hdev)
> >          struct qca_data *qca = hu->priv;
> >
> >          wait_on_bit_timeout(&qca->flags, QCA_MEMDUMP_COLLECTION,
> > -                           TASK_UNINTERRUPTIBLE, MEMDUMP_TIMEOUT_MS);
> > +                           TASK_UNINTERRUPTIBLE, msecs_to_jiffies(MEMDUMP_TIMEOUT_MS));
> >
> >          clear_bit(QCA_MEMDUMP_COLLECTION, &qca->flags);
> >   }
> > --
> > 2.34.1
> https://sashiko.dev/#/patchset/20260327082941.1396521-1-shuai.zhang%40oss.qualcomm.com
>
> Comments seem valid to me.

This comment is valid. I have addressed it in commit [1] by updating the 
completion path to use |clear_and_wake_up_bit()|.

https://lore.kernel.org/all/20260327083258.1398450-1-shuai.zhang@xxxxxxxxxxxxxxxx/


Thanks,

Shuai