RE: [PATCH v5 01/10] dt-bindings: clock: Add Realtek RTD1625 Clock & Reset Controller

[Yu-Chun Lin [林祐君]]

> Quoting Yu-Chun Lin (2026-03-23 19:53:22)
> > diff --git
> > a/Documentation/devicetree/bindings/clock/realtek,rtd1625-clk.yaml
> > b/Documentation/devicetree/bindings/clock/realtek,rtd1625-clk.yaml
> > new file mode 100644
> > index 000000000000..6fabc2da3975
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/realtek,rtd1625-clk.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/realtek,rtd1625-clk.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Realtek RTD1625 Clock & Reset Controller
> > +
> > +maintainers:
> > +  - Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> > +
> > +description: |
> > +  The Realtek RTD1625 Clock Controller manages and distributes clock
> > +  signals to various controllers and implements a Reset Controller
> > +for the
> > +  SoC peripherals.
> > +
> > +  Clocks and resets are referenced by unique identifiers, which are
> > + defined as  preprocessor macros in
> > + include/dt-bindings/clock/realtek,rtd1625-clk.h and
> include/dt-bindings/reset/realtek,rtd1625.h.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - realtek,rtd1625-crt-clk
> > +      - realtek,rtd1625-iso-clk
> > +      - realtek,rtd1625-iso-s-clk
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  "#clock-cells":
> > +    const: 1
> > +
> > +  "#reset-cells":
> > +    const: 1
> 
> Are there any input clks for the clk tree?
> 

We don't dynamically calculate frequencies based on an input clock.
Since all of our current SoCs use a fixed 27MHz oscillator, we use
predefined lookup tables in the driver for the target frequencies instead.

Nevertheless, to properly describe the hardware layout, I will add the clock
properties in the bindings and DTS in v6.

> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - "#clock-cells"
> > +  - "#reset-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    clock-controller@98000000 {
> > +      compatible = "realtek,rtd1625-crt-clk";
> > +      reg = <98000000 0x1000>;
> 
> Should be 0x98000000 to match the unit address.
> 

Ack.

Best Regards,
Yu-Chun

> > +      #clock-cells = <1>;
> > +      #reset-cells = <1>;
> > +    };