Re: [PATCH v5 4/4] platform: Add initial synology microp driver

[Krzysztof Kozlowski]

On 29/03/2026 20:02, Markus Probst via B4 Relay wrote:
> +
> +kernel::of_device_table!(
> +    pub(crate) OF_TABLE,
> +    MODULE_OF_TABLE,
> +    Model,
> +    models![
> +        apollolake @ [
> +            ds918p,
> +        ],
> +        evansport @ [
> +            ds214play,
> +        ],
> +        geminilakenk @ [
> +            ds225p.led_usb_copy(),
> +            ds425p,
> +        ],
> +        pineview @ [
> +            ds710p.led_esata(),
> +            ds1010p.led_alert(Color::Orange),
> +        ],
> +        r1000 @ [
> +            ds923p,
> +            ds723p,
> +            ds1522p,
> +            rs422p.led_power(Color::Green),
> +        ],
> +        r1000nk @ [
> +            ds725p,
> +        ],
> +        rtd1296 @ [
> +            ds118,
> +        ],
> +        rtd1619b @ [
> +            ds124,
> +            ds223.led_usb_copy(),
> +            ds223j,
> +        ],
> +        v1000 @ [
> +            ds1823xsp,
> +            rs822p.led_power(Color::Green),
> +            rs1221p.led_power(Color::Green),
> +            rs1221rpp.led_power(Color::Green),
> +        ],
> +        v1000nk @ [
> +            ds925p,
> +            ds1525p,
> +            ds1825p,
I don't see any compatible strings here. Actually, nowhere in the
driver. If that's how you write Rust drivers then NAK. Compatibles must
be greppable. Not only for humans but also for ABI check.

Best regards,
Krzysztof