Re: [PATCH 2/2] pinctrl: qcom: Drop redundant intr_target_reg on modern SoCs

[Linus Walleij]

On Fri, Mar 27, 2026 at 6:16 PM Mukesh Ojha
<mukesh.ojha@xxxxxxxxxxxxxxxx> wrote:

> On all Qualcomm TLMM generations from APQ8084 onwards, the interrupt
> target routing bits are located in the same register as the interrupt
> configuration bits (intr_cfg_reg). Only five older SoCs — APQ8064,
> IPQ8064, MDM9615, MSM8660 and MSM8960 — have a genuinely separate
> interrupt target routing register at a different offset (0x400 + 0x4 * id).
>
> Replace MSM_ACCESSOR(intr_target) with a custom accessor that falls back
> to intr_cfg_reg when intr_target_reg is zero. Apply the same fallback in
> the SCM path. Drop the now-redundant .intr_target_reg initializer from
> all SoC drivers where it duplicated intr_cfg_reg, keeping it only in
> the five drivers where it genuinely differs.
>
> Signed-off-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>

Patch applied so we get some rotation in linux-next for this. If Björn
has opinions
I will just pull it out again.

Yours,
Linus Walleij