Re: [PATCH] staging: fbtft: remove unnecessary parentheses and fix alignment
From: Andy Shevchenko
Date: Mon Mar 30 2026 - 04:42:44 EST
On Sun, Mar 29, 2026 at 7:36 PM Andrei Khomenkov <khomenkov@xxxxxxxxxxx> wrote:
> Fixed several checkpatch.pl CHECKs regarding unnecessary parentheses
> and alignment to improve code readability. These are coding style
> changes only.
NAK.
...
> write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
You should always use common sense.
...
Besides that, please read:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/fbtft/README?h=staging-next
and act accordingly.
--
With Best Regards,
Andy Shevchenko