Re: [PATCH] fs: write a better comment in step_into() concerning .mnt assignment

[Jan Kara]

On Sat 28-03-26 18:58:40, Mateusz Guzik wrote:
> Signed-off-by: Mateusz Guzik <mjguzik@xxxxxxxxx>

Nice. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/namei.c b/fs/namei.c
> index 2113958c3b7a..c7fac83c9a85 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -2140,7 +2140,7 @@ static __always_inline const char *step_into(struct nameidata *nd, int flags,
>  		if (unlikely(!inode))
>  			return ERR_PTR(-ENOENT);
>  		nd->path.dentry = dentry;
> -		/* nd->path.mnt is retained on purpose */
> +		/* nd->path.mnt remains unchanged as no mount point was crossed */
>  		nd->inode = inode;
>  		nd->seq = nd->next_seq;
>  		return NULL;
> -- 
> 2.48.1
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR