Re: [PATCH 1/1] crypto: jitterentropy - replace long-held spinlock with mutex
From: Herbert Xu
Date: Mon Mar 30 2026 - 04:58:11 EST
On Mon, Mar 30, 2026 at 03:23:46PM +0800, Haixin Xu wrote:
>
> @@ -298,7 +298,7 @@ static int jent_kcapi_random(struct crypto_rng *tfm,
> ret = -EINVAL;
> }
>
> - spin_unlock(&rng->jent_lock);
> + mutex_unlock(&rng->jent_lock);
Are you sure that this function never gets called from softirq
context?
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt