Re: [PATCH v3 11/38] drm/msm/dp: separate dp_display_prepare() into its own API

[Dmitry Baryshkov]

On Mon, Mar 30, 2026 at 05:46:09PM +0800, Yongxing Mou wrote:
> 
> 
> On 8/26/2025 1:39 AM, Dmitry Baryshkov wrote:
> > On Mon, Aug 25, 2025 at 10:15:57PM +0800, Yongxing Mou wrote:
> > > From: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> > > 
> > > dp_display_prepare() only prepares the link in case its not
> > > already ready before dp_display_enable(). Hence separate it into
> > > its own API.
> > 
> > Why?
> > 
> In the MST use case, this is expected to work as follows: when multiple
> sinks (two or more) need to be enabled, dp_display_prepare() handles
> link-related setup and should only be executed once, while
> dp_display_enable() is responsible for stream-related handling and may be
> executed multiple times.

Then you need to write a better commit message.

> > > 
> > > Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> > > Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
> > > ---
> > >   drivers/gpu/drm/msm/dp/dp_display.c | 16 ++++++++++++----
> > >   drivers/gpu/drm/msm/dp/dp_display.h |  1 +
> > >   drivers/gpu/drm/msm/dp/dp_drm.c     |  2 ++
> > >   3 files changed, 15 insertions(+), 4 deletions(-)
> > > 
> > 
> 

-- 
With best wishes
Dmitry