Re: [PATCH v3 05/38] drm/msm/dp: splite msm_dp_ctrl_config_ctrl() into link parts and stream parts

[Dmitry Baryshkov]

On Mon, Mar 30, 2026 at 05:00:56PM +0800, Yongxing Mou wrote:
> 
> 
> On 8/26/2025 1:28 AM, Dmitry Baryshkov wrote:
> > On Mon, Aug 25, 2025 at 10:15:51PM +0800, Yongxing Mou wrote:
> > > The DP_CONFIGURATION_CTRL register contains both link-level and
> > > stream-specific fields. Currently, msm_dp_ctrl_config_ctrl() configures
> > > all of them together, which makes it harder to support MST.
> > > 
> > > This patch separates the configuration into two functions:
> > 
> > git grep "This patch" Documentation/process
> > Got it. Will fix it next patch.
> > > - msm_dp_ctrl_config_ctrl_link(): handles link-related fields
> > > - msm_dp_ctrl_config_ctrl_streams(): handles stream-specific fields
> > > 
> > > It also moves the link-related configuration out of
> > > msm_dp_ctrl_configure_source_params().
> > 
> > Why? And it looks like a separate patch...
> > 
> Because the patches following msm_dp_ctrl_configure_source_params() will
> take a panel parameter, and lane_mapping and peripheral_flush seem to be
> more closely related to the link, they have been moved out.

This still looks like a separate patch.

> > > 
> > > Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
> > > ---
> > >   drivers/gpu/drm/msm/dp/dp_ctrl.c | 49 +++++++++++++++++++++++++---------------
> > >   1 file changed, 31 insertions(+), 18 deletions(-)
> > > 

-- 
With best wishes
Dmitry