Re: [PATCH] crypto: ccree: fix a memory leak in cc_mac_digest()
From: Markus Elfring
Date: Mon Mar 30 2026 - 07:45:16 EST
…
> +++ b/drivers/crypto/ccree/cc_hash.c
> @@ -1448,6 +1448,7 @@ static int cc_mac_digest(struct ahash_request *req)
> if (cc_map_hash_request_final(ctx->drvdata, state, req->src,
> req->nbytes, 1, flags)) {
> dev_err(dev, "map_ahash_request_final() failed\n");
> + cc_unmap_result(dev, state, digestsize, req->result);
> cc_unmap_req(dev, state, ctx);
> return -ENOMEM;
> }
How do you think about to avoid also a bit of duplicate source code here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.0-rc6#n526
Regards,
Markus