Re: [PATCH 1/2] ALSA: hda/realtek: add quirk for HP Laptop 15-fc0xxx

[Takashi Iwai]

On Mon, 30 Mar 2026 09:53:33 +0200,
Zhang Heng wrote:
> 
> For the HP Laptop 15-fc0xxx with ALC236, the built-in mic 0x12 was
> not set up, making it unusable; after adding it, it now works properly.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=221233
> Signed-off-by: Zhang Heng <zhangheng@xxxxxxxxxx>
> ---
>  sound/hda/codecs/realtek/alc269.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 6787e54fcfe6..0fd980596408 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -4123,6 +4123,7 @@ enum {
>  	ALC245_FIXUP_BASS_HP_DAC,
>  	ALC245_FIXUP_ACER_MICMUTE_LED,
>  	ALC245_FIXUP_CS35L41_I2C_2_MUTE_LED,
> +	ALC236_FIXUP_HP_INV_DMIC,

Any reason for "_INV_"?  Your implementation doesn't look related with
the existing inverted dmic workaround.


thanks,

Takashi

>  };
>  
>  /* A special fixup for Lenovo C940 and Yoga Duet 7;
> @@ -6658,6 +6659,13 @@ static const struct hda_fixup alc269_fixups[] = {
>  		.v.func = alc245_fixup_hp_mute_led_coefbit,
>  		.chained = true,
>  		.chain_id = ALC287_FIXUP_CS35L41_I2C_2,
> +	},
> +	[ALC236_FIXUP_HP_INV_DMIC] = {
> +		.type = HDA_FIXUP_PINS,
> +		.v.pins = (const struct hda_pintbl[]) {
> +			{ 0x12, 0x90a60160 }, /* use as internal mic */
> +			{ }
> +		},
>  	}
>  };
>  
> @@ -7152,6 +7160,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x8da1, "HP 16 Clipper OmniBook X", ALC287_FIXUP_CS35L41_I2C_2),
>  	SND_PCI_QUIRK(0x103c, 0x8da7, "HP 14 Enstrom OmniBook X", ALC287_FIXUP_CS35L41_I2C_2),
>  	SND_PCI_QUIRK(0x103c, 0x8da8, "HP 16 Piston OmniBook X", ALC287_FIXUP_CS35L41_I2C_2),
> +	SND_PCI_QUIRK(0x103c, 0x8dc9, "HP Laptop 15-fc0xxx", ALC236_FIXUP_HP_INV_DMIC),
>  	SND_PCI_QUIRK(0x103c, 0x8dd4, "HP EliteStudio 8 AIO", ALC274_FIXUP_HP_AIO_BIND_DACS),
>  	SND_PCI_QUIRK(0x103c, 0x8dd7, "HP Laptop 15-fd0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>  	SND_PCI_QUIRK(0x103c, 0x8de8, "HP Gemtree", ALC245_FIXUP_TAS2781_SPI_2),
> -- 
> 2.25.1
>