Re: [PATCH v3 12/38] drm/msm/dp: introduce max_streams for DP controller MST support

[Yongxing Mou]

On 3/30/2026 7:42 PM, Dmitry Baryshkov wrote:
> On Mon, Mar 30, 2026 at 07:32:38PM +0800, Yongxing Mou wrote:
> > On 3/30/2026 6:35 PM, Dmitry Baryshkov wrote:
> > > On Mon, Mar 30, 2026 at 05:57:13PM +0800, Yongxing Mou wrote:
> > > > On 8/26/2025 1:42 AM, Dmitry Baryshkov wrote:
> > > > > On Mon, Aug 25, 2025 at 10:15:58PM +0800, Yongxing Mou wrote:
> > > > > > From: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> > > > > >
> > > > > > Introduce the `mst_streams` field in each DP controller descriptor to
> > > > > > specify the number of supported MST streams. Most platforms support 2 or
> > > > > > 4 MST streams, while platforms without MST support default to a single
> > > > > > stream (`DEFAULT_STREAM_COUNT = 1`).
> > > > > >
> > > > > > This change also accounts for platforms with asymmetric stream support,
> > > > > > e.g., DP0 supporting 4 streams and DP1 supporting 2.
> > > > >
> > > > > How?
> > > > Each DP controller have it own msm_dp_desc ...
> > >
> > > Why do you need to mention it?
> > Sorry, I may have misunderstood your “How?”. Could you please clarify what
> > aspect you are referring to (commit message wording vs. the actual
> > implementation)?
>
> "Yes." You mention it as if something was done explicitly to account for
> those differences. And then fail to say, what / how. My assumtion is
> that this comes from the commit text style (see
> Documentation/process/submitting-patches.rst). Please use imperative
> language rather than descriptive. It will make such questions go away.
Thanks for the clarification and for pointing this out. Will rework the 
commit message in the next revision.
> > > > > > Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> > > > > > Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>