Re: [RFT PATCH v3] ARM: omap1: enable real software node lookup of GPIOs on Nokia 770

From: Bartosz Golaszewski

Date: Mon Mar 30 2026 - 08:34:15 EST


On Mon, Mar 30, 2026 at 10:43 AM Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
>
> > > Thanks. This makes sense. Both omap16xx_gpio_init() and
> > > software_node_init() run as postcore_initcall() so if the order is not
> > > right, it will fail.
> > >
> > > Cc'ing Andy who's a reviewer for software nodes. Andy: is there any
> > > reason to run software_node_init() as a postcore initcall? It only
> > > allocates the kset, can we move it to core_initcall() by any chance?
> >
> > Good question. I don't know why it's chosen like this.
> > Let ask Heikki, who is the author of the code.
>
> I don't remember why it was it made a postcore initcall (I only
> remember that there was some reason at the time). It's probable
> fine to just make it a core initcall.
>

We can't really make it a core_initcall() either - kernel_kobj on
which software nodes depend is currently initialized in a
core_initcall() which could have been the reason for putting
software_node_init() in a postcore_initcall(). I think both
kernel_kobj and software nodes should be made available earlier.

Bart