Re: [PATCH 2/2] arm64: dts: qcom: Add Motorola edge 30 (dubai) DTS

[Val Packett]

On 3/30/26 7:03 AM, Konrad Dybcio wrote:
> On 3/29/26 12:16 PM, Val Packett wrote:
> > The Motorola edge 30 is a smartphone released in 2022.
> >
> > This commit has the following features working:
> > - Display (simplefb)
> > - Touchscreen
> > - Power and volume buttons
> > - Storage (UFS 3.1)
> > - Battery (ADSP battmgr)
> > - USB (Type-C, 2.0, dual-role)
> > - Wi-Fi and Bluetooth (WCN6750 hw1.0)
> >
> > Signed-off-by: Val Packett <val@xxxxxxxxxxxx>
> > ---
> [...]
>
> > +/ {
> > +	model = "Motorola edge 30";
> nit: Google tells me the 'e' in 'Edge' is uppercase
They do the lowercase thing a lot in the marketing materials but not 
consistently. I guess it would make sense to ignore that and make it 
uppercase, sure.
> [...]
>
> > +		framebuffer0: framebuffer@e1000000 {
> > +			compatible = "simple-framebuffer";
> > +			reg = <0x0 0xe1000000 0x0 (1080 * 2400 * 4)>;
> Let's drop reg and use the memory-region binding (also drop unit address)
How come no one told be about memory-region for simplefb before? :D Ack
> [...]
> > +			ports {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				port@0 {
> > +					reg = <0>;
> > +
> > +					pmic_glink_hs_in: endpoint {
> > +						remote-endpoint = <&usb_1_dwc3_hs>;
> > +					};
> > +				};
> > +
> > +				port@1 {
> > +					reg = <1>;
> SBU would be @2
I was wondering about this, now I see it is specified in the bindings.. 
Looks like many other dts should be fixed too.
> > +		cont-splash@e1000000 {
> framebuffer@
>
> [...]
>
> > +	thermal-zones {
> > +		cam-flash-thermal {
> > +			polling-delay-passive = <0>;
> that's the default setting, you may drop all polling-delay(-passive) = <0>
ack
> [...]
>
> > +&usb_1 {
> > +	/* USB 2.0 only */
> > +	qcom,select-utmi-as-pipe-clk;
> > +	maximum-speed = "high-speed";
> > +
> > +	/* Remove USB3 phy */
> > +	phys = <&usb_1_hsphy>;
> > +	phy-names = "usb2-phy";
> Is it really not wired up in hw, or do you perhaps have a fake cable?

I didn't even try testing it myself since not even all flagships have 
USB3 routed these days (hello oneplus) and this is a cheaper 
upper-mid-range phone.

USB0_{SS_*,DP_*} are actually NC on the schematic,

and in downstream dts there is maximum-speed = "high-speed" and usb-phy 
= hsphy + nop.

~val