Re: [PATCH 2/2] staging: rtl8723bs: fix coding style and remove dead code

[Greg KH]

On Thu, Mar 26, 2026 at 01:42:21AM +0000, Marcos Andrade wrote:
> Fix various coding style issues in rtw_wlan_util.c to align the code
> with the Linux kernel formatting standards.
> 
> Specifically, this patch:
> - Resolves lines exceeding the 80-column limit.
> - Removes redundant and unnecessary parentheses in complex conditionals.
> - Deletes commented-out dead code that clutters the logic.
> - Fixes alignment to correctly match open parentheses.
> 
> These changes improve overall code readability and address multiple
> checks reported by checkpatch.pl. No functional changes are introduced.
> 
> Signed-off-by: Marcos Andrade <marcosandrade95963@xxxxxxxxx>
> ---
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot