Re: [PATCH] rtla: Fix build without libbpf header

[Wander Lairson Costa]

On Mon, Mar 30, 2026 at 11:12:07AM +0200, Tomas Glozar wrote:
> rtla supports building without libbpf. However, BPF actions
> patchset [1] adds an include of bpf/libbpf.h into timerlat_bpf.h,
> which breaks build on systems that don't have libbpf headers
> installed.
> 
> This is a leftover from a draft version of the patchset where
> timerlat_bpf_set_action() (which takes a struct bpf_program * argument)
> was defined in the header. timerlat_bpf.c already includes bpf/libbpf.h
> via timerlat.skel.h when libbpf is present.
> 
> Remove the redundant include to fix build on systems without libbpf
> headers.
> 
> [1] https://lore.kernel.org/linux-trace-kernel/20251126144205.331954-1-tglozar@xxxxxxxxxx/T/
> 
> Reported-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-trace-kernel/20260329122202.65a8b575@robin/
> Fixes: 8cd0f08ac72e ("rtla/timerlat: Support tail call from BPF program")
> Signed-off-by: Tomas Glozar <tglozar@xxxxxxxxxx>
> ---
>  tools/tracing/rtla/src/timerlat_bpf.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/tracing/rtla/src/timerlat_bpf.h b/tools/tracing/rtla/src/timerlat_bpf.h
> index 169abeaf4363..f7c5675737fe 100644
> --- a/tools/tracing/rtla/src/timerlat_bpf.h
> +++ b/tools/tracing/rtla/src/timerlat_bpf.h
> @@ -12,7 +12,6 @@ enum summary_field {
>  };
>  
>  #ifndef __bpf__
> -#include <bpf/libbpf.h>
>  #ifdef HAVE_BPF_SKEL
>  int timerlat_bpf_init(struct timerlat_params *params);
>  int timerlat_bpf_attach(void);
> -- 
> 2.53.0
> 

Reviewed-by: Wander Lairson Costa <wander@xxxxxxxxxx>