Re: [PATCH 14/14] media: rzg2l-cru: Simplify irq return value handling

[Tommaso Merciai]

Hi Jacopo,
Thanks for your patch.

On Fri, Mar 27, 2026 at 06:10:19PM +0100, Jacopo Mondi wrote:
> From: Jacopo Mondi <jacopo.mondi+renesas@xxxxxxxxxxxxxxxx>
> 
> The rzg2l_cru_irq() irq handler uses a local variable to store the
> handler return value.
> 
> Simplify it by using IRQ_NONE and IRQ_HANDLED.
> 

Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@xxxxxxxxxxxxxx>

Kind Regards,
Tommaso

> Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> index 30424e2b6cc0..e81573d0a84c 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> @@ -592,16 +592,13 @@ static void rzg2l_cru_stop_streaming(struct rzg2l_cru_dev *cru)
>  irqreturn_t rzg2l_cru_irq(int irq, void *data)
>  {
>  	struct rzg2l_cru_dev *cru = data;
> -	unsigned int handled = 0;
>  	u32 irq_status;
>  	u32 amnmbs;
>  	int slot;
>  
>  	irq_status = rzg2l_cru_read(cru, CRUnINTS);
>  	if (!irq_status)
> -		return IRQ_RETVAL(handled);
> -
> -	handled = 1;
> +		return IRQ_NONE;
>  
>  	rzg2l_cru_write(cru, CRUnINTS, rzg2l_cru_read(cru, CRUnINTS));
>  
> @@ -638,7 +635,7 @@ irqreturn_t rzg2l_cru_irq(int irq, void *data)
>  	/* Prepare for next frame */
>  	rzg2l_cru_fill_hw_slot(cru, slot);
>  
> -	return IRQ_RETVAL(handled);
> +	return IRQ_HANDLED;
>  }
>  
>  irqreturn_t rzg3e_cru_irq(int irq, void *data)
> 
> -- 
> 2.53.0
>