Re: [PATCH v3] dt-bindings: sound: Convert pcm3060 to DT Schema

[Padmashree S S]

On Mon, Mar 30, 2026 at 11:19 AM Kirill Marinushkin
<k.marinushkin@xxxxxxxxx> wrote:
>
> Hello Padmashree,
>
>
> overall, your proposed changes look good to me, thank you for taking care of
>
> the DT schema for the pcm3060 driver!
>
> I left a few minor comments below, but i am open for a discussion, if
> you think
>
> they are not relevant
>
>
> On 3/27/26 1:19 PM, Padmashree S S wrote:
> > Convert pcm3060 to DT Schema
> >
> > Signed-off-by: Padmashree S S <padmashreess2006@xxxxxxxxx>
> > ---
> >   .../devicetree/bindings/sound/pcm3060.txt     | 23 ----------
> >   .../devicetree/bindings/sound/pcm3060.yaml    | 42 +++++++++++++++++++
> >   2 files changed, 42 insertions(+), 23 deletions(-)
> >   delete mode 100644 Documentation/devicetree/bindings/sound/pcm3060.txt
> >   create mode 100644 Documentation/devicetree/bindings/sound/pcm3060.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/pcm3060.txt b/Documentation/devicetree/bindings/sound/pcm3060.txt
> > deleted file mode 100644
> > index 97de66932d44..000000000000
> > --- a/Documentation/devicetree/bindings/sound/pcm3060.txt
> > +++ /dev/null
> > @@ -1,23 +0,0 @@
> > -PCM3060 audio CODEC
> > -
> > -This driver supports both I2C and SPI.
> > -
> > -Required properties:
> > -
> > -- compatible: "ti,pcm3060"
> > -
> > -- reg : the I2C address of the device for I2C, the chip select
> > -        number for SPI.
> > -
> > -Optional properties:
> > -
> > -- ti,out-single-ended: "true" if output is single-ended;
> > -                       "false" or not specified if output is differential.
> > -
> > -Examples:
> > -
> > -     pcm3060: pcm3060@46 {
> > -              compatible = "ti,pcm3060";
> > -              reg = <0x46>;
> > -              ti,out-single-ended = "true";
> > -     };
> > diff --git a/Documentation/devicetree/bindings/sound/pcm3060.yaml b/Documentation/devicetree/bindings/sound/pcm3060.yaml
> > new file mode 100644
> > index 000000000000..2d920a70bced
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/pcm3060.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/pcm3060.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: PCM3060 audio CODEC
>
>
> Here, we seem to drop a short description, that this driver supports
>
> I2C and SPI. It's maybe not a big deal, but maybe we could return these
> details,
>
> as a `description` property? Let me know what you think
>
>
> > +
> > +maintainers:
> > +  - Kirill Marinushkin <k.marinushkin@xxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    const: ti,pcm3060
> > +
> > +  reg:
> > +    maxItems: 1
>
>
> Here, i notice, that we remove the description of the `reg` property.
>
> It was there originally, and in the 1st version of your patch, but not
> in v3.
>
> The description here seems important to me - being a documentation, this
>
> yaml could be more helpful, when it describes the meaning of the properties.
>
> Do you think it would be possible to bring the description back?
>
>
> > +
> > +  ti,out-single-ended:
> > +    type: boolean
> > +    description: |
> > +      If present, the output is single-ended.
> > +      If absent, the output is differential.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +      #address-cells = <1>;
> > +      #size-cells = <0>;
> > +
> > +      pcm3060: audio-codec@46 {
> > +        compatible = "ti,pcm3060";
> > +        reg = <0x46>;
> > +        ti,out-single-ended;
> > +      };
> > +    };
>
>
> Best regards,
>
> Kirill
>
>Thank you for the feedback, I will bring back the descriptions in the next version of this patch.