Re: [PATCH 1/2] staging: rtl8723bs: Remove dead code

[Dan Carpenter]

On Mon, Mar 30, 2026 at 11:55:09AM -0500, Ethan Tidmore wrote:
> @@ -413,17 +408,14 @@ void update_bmc_sta(struct adapter *padapter)
>  		/* ap mode */
>  		rtw_hal_set_odm_var(padapter, HAL_ODM_STA_INFO, psta, true);
>  
> -		/* if (pHalData->fw_ractrl == true) */
> -		{
> -			u8 arg[4] = {0};
> +		u8 arg[4] = {0};
>  

Now there is a declaration in the middle of the code which isn't
normal style unless it's a __cleanup pointer.  I would probably
just leave this comment as-is so it serves as documentation that
something weird and historicaly is going on here.

regards,
dan carpenter

> -			arg[0] = psta->mac_id;
> -			arg[1] = psta->raid;
> -			arg[2] = 0;
> -			arg[3] = psta->init_rate;
> +		arg[0] = psta->mac_id;
> +		arg[1] = psta->raid;
> +		arg[2] = 0;
> +		arg[3] = psta->init_rate;
>  
> -			rtw_hal_add_ra_tid(padapter, tx_ra_bitmap, arg, 0);
> -		}
> +		rtw_hal_add_ra_tid(padapter, tx_ra_bitmap, arg, 0);
>  
>  		rtw_sta_media_status_rpt(padapter, psta, 1);
>