Re: [PATCH v5 1/4] dt-bindings: embedded-controller: Add synology microp devices

[Markus Probst]

On Mon, 2026-03-30 at 08:51 +0200, Krzysztof Kozlowski wrote:
> On Sun, Mar 29, 2026 at 08:02:15PM +0200, Markus Probst wrote:
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - synology,ds923p-microp
> > +      - synology,ds918p-microp
> > +      - synology,ds214play-microp
> > +      - synology,ds225p-microp
> > +      - synology,ds425p-microp
> > +      - synology,ds710p-microp
> > +      - synology,ds1010p-microp
> > +      - synology,ds723p-microp
> > +      - synology,ds1522p-microp
> > +      - synology,rs422p-microp
> > +      - synology,ds725p-microp
> > +      - synology,ds118-microp
> > +      - synology,ds124-microp
> > +      - synology,ds223-microp
> > +      - synology,ds223j-microp
> > +      - synology,ds1823xsp-microp
> > +      - synology,rs822p-microp
> > +      - synology,rs1221p-microp
> > +      - synology,rs1221rpp-microp
> > +      - synology,ds925p-microp
> > +      - synology,ds1525p-microp
> > +      - synology,ds1825p-microp
> 
> Last time you had one compatible and implied they are all compatible.
> Now none of them are compatible, which might be accurate,

As you mentioned earlier:

Unless exactly same board is used
in different models (unlikely) then the compatible defines the LEDs and
they are not needed in DT.

> 
> but nothing
> explains WHY they are not compatible in the commit msg.
Shall all 22 compatible be in the commit msg?

Also, might be worth documenting this requirement [1].

> 
> > +
> > +  fan-failure-gpios:
> > +    description: GPIOs needed to determine which fans stopped working on a fan failure event.
> > +    minItems: 2
> > +    maxItems: 3
> 
> Constraints cannot be flexible. You need allOf:if:then: block to narrow
> them per variant.
I can disable the property or force the property based on compatible
with it.
But it seems it won't let me modify the minItems and maxItems
constraint.

Thanks
- Markus Probst


[1] https://docs.kernel.org/devicetree/bindings/submitting-patches.html


> 
> Best regards,
> Krzysztof

Attachment: signature.asc
Description: This is a digitally signed message part