Re: [PATCH v2 05/10] drm/bridge: dw-hdmi: document the output_port field

[Damon Ding]

On 3/31/2026 3:25 AM, Luca Ceresoli wrote:
> The meaning of this flag may not be obvious at first sight.
>
> Reviewed-by: Liu Ying <victor.liu@xxxxxxx>
> Tested-by: Martyn Welch <martyn.welch@xxxxxxxxxxxxx>
> Tested-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> # TQMa8MPxL/MBa8MPxL
> Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
>
> ---
>
> Changes in v2:
> - improved comment as suggested by Liu
> ---
>   include/drm/bridge/dw_hdmi.h | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h
> index 336f062e1f9d..8500dd4f99d8 100644
> --- a/include/drm/bridge/dw_hdmi.h
> +++ b/include/drm/bridge/dw_hdmi.h
> @@ -126,6 +126,12 @@ struct dw_hdmi_phy_ops {
>   struct dw_hdmi_plat_data {
>   	struct regmap *regm;
>   
> +	/*
> +	 * The HDMI output port number must be 1 if the port is described
> +	 * in the device tree. 0 if the device tree does not describe the
> +	 * next component (legacy mode, i.e. without
> +	 * DRM_BRIDGE_ATTACH_NO_CONNECTOR flag when attaching bridge).
> +	 */
>   	unsigned int output_port;
>   
>   	unsigned long input_bus_encoding;

Tested-by: Damon Ding <damon.ding@xxxxxxxxxxxxxx> (on rk3399)

Best regards,
Damon