Re: [PATCH 06/14] media: rzg2l-cru: Do not use irqsave when not needed

[Lad, Prabhakar]

On Fri, Mar 27, 2026 at 5:22 PM Jacopo Mondi
<jacopo.mondi@xxxxxxxxxxxxxxxx> wrote:
>
> From: Jacopo Mondi <jacopo.mondi+renesas@xxxxxxxxxxxxxxxx>
>
> The return_unused_buffers() and rzg2l_cru_buffer_queue() functions
> are never called from an interrupt context, hence they do not need to
> use the irqsave version of the spinlock primitives.
>
> Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> index 43b1d35fb963..2e94788c3a13 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> @@ -113,7 +113,7 @@ static void return_unused_buffers(struct rzg2l_cru_dev *cru,
>         struct rzg2l_cru_buffer *buf, *node;
>         unsigned int i;
>
> -       guard(spinlock_irqsave)(&cru->qlock);
> +       guard(spinlock_irq)(&cru->qlock);
>
>         for (i = 0; i < cru->num_buf; i++) {
>                 if (cru->queue_buf[i]) {
> @@ -166,7 +166,7 @@ static void rzg2l_cru_buffer_queue(struct vb2_buffer *vb)
>         struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
>         struct rzg2l_cru_dev *cru = vb2_get_drv_priv(vb->vb2_queue);
>
> -       guard(spinlock_irqsave)(&cru->qlock);
> +       guard(spinlock_irq)(&cru->qlock);
>         list_add_tail(to_buf_list(vbuf), &cru->buf_list);
>  }
>
>
> --
> 2.53.0
>
>