Re: [PATCH RESEND 4/4] PM / devfreq: Optimize error return value of governor_show()

[Yaxiong Tian]

在 2026/3/31 15:21, Jie Zhan 写道:
> On 3/19/2026 5:17 PM, Yaxiong Tian wrote:
> > When df->governor is NULL, governor_show() returns -EINVAL, which
> > confuses users.
> >
> > To fix this issue, return -ENOENT to indicate that no governor is
> > currently set for the device.
> >
> > Signed-off-by: Yaxiong Tian <tianyaxiong@xxxxxxxxxx>
> > ---
> >   drivers/devfreq/devfreq.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> > index 4a312f3c2421..7cc60711fafd 100644
> > --- a/drivers/devfreq/devfreq.c
> > +++ b/drivers/devfreq/devfreq.c
> > @@ -1412,7 +1412,7 @@ static ssize_t governor_show(struct device *dev,
> >   	struct devfreq *df = to_devfreq(dev);
> >   
> >   	if (!df->governor)
> > -		return -EINVAL;
> > +		return -ENOENT;
> What about -ENODEV?
I think a governor is not a device, so -ENOENT would be more appropriate.
> >   
> >   	return sprintf(buf, "%s\n", df->governor->name);
> >   }