Re: [PATCH net-next] pppoe: update Kconfig URLs
From: Jaco Kroon
Date: Tue Mar 31 2026 - 04:22:59 EST
Hi,
On 2026/03/31 09:54, Qingfang Deng wrote:
Hi,
On Tue, 31 Mar 2026 08:21:40 +0200, Jaco Kroon wrote:
On 2026/03/31 05:33, Qingfang Deng wrote:Thanks for the information.
--- a/drivers/net/ppp/Kconfigppp now exclusively has the plugin code (originally from roaring penguin
+++ b/drivers/net/ppp/Kconfig
@@ -122,11 +122,10 @@ config PPPOE
help
Support for PPP over Ethernet.
- This driver requires the latest version of pppd from the CVS
- repository at cvs.samba.org. Alternatively, see the
- RoaringPenguin package (<http://www.roaringpenguin.com/pppoe>)
- which contains instruction on how to use this driver (under
- the heading "Kernel mode PPPoE").
+ This driver requires the latest version of pppd at
+ <https://ppp.samba.org>.
+ Alternatively, see the out-of-tree RP-PPPoE plugin at
+ <https://dianne.skoll.ca/projects/rp-pppoe/>.
I believe). Latest version is no longer relevant, that plugin has been
available since at least a few versions back already (at least a decade,
probably closer to two).
That same code has recently been dropped from rp-pppoe, which now
primarily focusses on pppoe-server, and relies on the plugin now part of
ppp package itself. rp-pppoe is only required if you're running a
pppoe-server, and I don't think rp-pppoe at this stage will function
without ppp.
Most people will never need rp-pppoe.
I just checked pppd's changelog: version 2.4.2 or later has the PPPoE
plugin.
I can update the help message accordingly:
To work in client mode, pppd version 2.4.2 or later is
required. To work in server mode, the pppoe-server command
from the RP-PPPoE package is also required, available at
<https://dianne.skoll.ca/projects/rp-pppoe/>.
I like this. You have however dropped the ppp.samba.org link, just re-add that I reckon.
Signed-off-by: Jaco Kroon <jaco@xxxxxxxxx>
For what my sign-off is worth in this case :).
Kind regards,
Jaco