Re: [PATCH v15 3/3] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board

[tessolveupstream]

On 02-03-2026 18:43, Dmitry Baryshkov wrote:
> On Mon, Mar 02, 2026 at 05:41:59PM +0530, Sudarshan Shetty wrote:
>> Add the device tree for the QCS615-based Talos EVK platform. The
>> platform is composed of a System-on-Module following the SMARC
>> standard, and a Carrier Board.
>>
>> The Carrier Board supports several display configurations, HDMI and
>> LVDS. Both configurations use the same base hardware, with the display
>> selection controlled by a DIP switch.
>>
>> Use a DTBO file, talos-evk-lvds-auo,g133han01.dtso, which defines an
>> overlay that disables HDMI and adds LVDS. The DTs file talos-evk
>> can describe the HDMI display configurations.
>>
>> According to the hardware design and vendor guidance, the WiFi PA
>> supplies VDD_PA_A and VDD_PA_B only need to be enabled at the same time
>> as asserting WLAN_EN.
>>
>> On this platform, WiFi enablement is controlled via the WLAN_EN GPIO
>> (GPIO84), which also drives the VDD_PA_A and VDD_PA_B power enables.
>> Remove the VDD_PA_A and VDD_PA_B regulator nodes from the device tree
>> and rely on WLAN_EN to enable WiFi functionality.
>>
>> Add talos-evk-usb1-peripheral.dtso overlay to enable USB0 peripheral
>> (EDL) mode. The base DTS will keep USB0 host-only due to hardware
>> routing through the EDL DIP switch, and the overlay switches the
>> configuration for device-mode operation.
>>
>> The LVDS backlight hardware has been updated to use a simplified
>> design. The backlight enable signal is now permanently pulled up
>> to 3.3V and is no longer controlled via GPIO59.
>>
>> Remove the GPIO59 based backlight configuration from the device
>> tree, as it is no longer routed to the LVDS interface.
>>
>> The initial device tree includes support for:
>> - CPU and memory
>> - UART
>> - GPIOs
>> - Regulators
>> - PMIC
>> - Early console
>> - AT24MAC602 EEPROM
>> - MCP2515 SPI to CAN
>> - ADV7535 DSI-to-HDMI bridge
>> - DisplayPort interface
>> - SN65DSI84ZXHR DSI-to-LVDS bridge
>> - Wi-Fi/BT
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Sudarshan Shetty <tessolveupstream@xxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/Makefile             |   6 +
>>  .../qcom/talos-evk-lvds-auo,g133han01.dtso    | 127 ++++
>>  arch/arm64/boot/dts/qcom/talos-evk-som.dtsi   | 614 ++++++++++++++++++
>>  .../dts/qcom/talos-evk-usb1-peripheral.dtso   |  10 +
>>  arch/arm64/boot/dts/qcom/talos-evk.dts        | 139 ++++
>>  5 files changed, 896 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso
>>  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
>>  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-usb1-peripheral.dtso
>>  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts
> 
>> +
>> +	regulator-usb2-vbus {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "USB2_VBUS";
>> +		gpio = <&pm8150_gpios 10 GPIO_ACTIVE_HIGH>;
>> +		pinctrl-0 = <&usb2_en>;
>> +		pinctrl-names = "default";
>> +		enable-active-high;
>> +		regulator-always-on;
>> +	};
> 
> Hmm. I hoped that we are past this stage. Please order the nodes.
>

Okay, will take care in the next patch series.
 
>> +
>> +	vreg_conn_1p8: regulator-conn-1p8 {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vreg_conn_1p8";
>> +		startup-delay-us = <4000>;
>> +		enable-active-high;
>> +		gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
>> +	};
>> +
>> +	vreg_conn_pa: regulator-conn-pa {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vreg_conn_pa";
>> +		startup-delay-us = <4000>;
>> +		enable-active-high;
>> +		gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>;
>> +	};
>> +
>> +	vreg_v3p3_can: regulator-v3p3-can {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vreg-v3p3-can";
>> +		regulator-min-microvolt = <3300000>;
>> +		regulator-max-microvolt = <3300000>;
>> +		regulator-boot-on;
>> +		regulator-always-on;
>> +	};
>> +
>> +	vreg_v5p0_can: regulator-v5p0-can {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vreg-v5p0-can";
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-max-microvolt = <5000000>;
>> +		regulator-boot-on;
>> +		regulator-always-on;
>> +	};
>> +
> 
> [...]
> 
>> +
>> +/*
>> + * USB0 routing and EDL mode:
>> + *
>> + * The USB0 controller’s HS differential pair is switched (manually)
>> + * between the Micro-USB port for EDL/ADB and the on-board USB 3.0 hub.
>> + *
>> + * During EDL (Emergency Download) mode, the HS lines are explicitly
>> + * routed to the Micro-USB port to allow the SoC to enter device mode
>> + * for flashing.
>> + *
>> + * After EDL the switch is normally toggled so the HS lines stay
>> + * connected to the hub’s Type-A downstream ports, leaving no electrical
>> + * path to the Micro-USB connector — therefore USB0 runs host-only in
>> + * normal runtime and device mode must not be advertised.
>> + *
>> + * USB0 is configured host-only in the base device tree; a separate
>> + * device-tree overlay enables the Micro-USB peripheral configuration for
>> + * ADB. For ADB to work during normal runtime the DIP switch SW1 must be
>> + * manually toggled to the off position (reconnecting the HS pair to the
>> + * Micro-USB port).
>> + */
>> +
>> +&usb_1 {
>> +	status = "okay";
>> +};
>> +
> 
> 
>> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-usb1-peripheral.dtso b/arch/arm64/boot/dts/qcom/talos-evk-usb1-peripheral.dtso
>> new file mode 100644
>> index 000000000000..2f4630a6ba66
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/talos-evk-usb1-peripheral.dtso
>> @@ -0,0 +1,10 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>> + */
>> +/dts-v1/;
>> +/plugin/;
> 
> Comment, what should be changed to make use of it.
> 

Sure, will add it in the next patch series.
>> +
>> +&usb_1_dwc3 {
>> +        dr_mode = "peripheral";
>> +};
>