Re: [PATCH 07/17] KVM: x86/tdp_mmu: Centralize updates to present external PTEs

From: Huang, Kai

Date: Tue Mar 31 2026 - 06:13:08 EST



> @@ -1373,6 +1396,9 @@ static void kvm_tdp_mmu_age_spte(struct kvm *kvm, struct tdp_iter *iter)
> {
> u64 new_spte;
>
> + if (WARN_ON_ONCE(is_mirror_sptep(iter->sptep)))
> + return;
> +
> if (spte_ad_enabled(iter->old_spte)) {
> iter->old_spte = tdp_mmu_clear_spte_bits_atomic(iter->sptep,
> shadow_accessed_mask);

AFAICT this chunk isn't related to "Centralize updates to present external
PTEs"? Should it be in a separate patch?