Re: [PATCH v6 1/4] platform/x86: int3472: Use local variable for LED struct access

From: Andy Shevchenko

Date: Tue Mar 31 2026 - 06:21:27 EST


On Tue, Mar 31, 2026 at 09:52:01AM +0200, Marco Nenciarini wrote:
> Introduce a local struct int3472_pled pointer in the LED registration,
> unregistration, and brightness callback functions to avoid repeatedly
> dereferencing int3472->pled. In the brightness callback, use
> container_of() to get the int3472_pled struct directly instead of
> going through int3472_discrete_device.
>
> No functional change.

...

> static int int3472_pled_set(struct led_classdev *led_cdev,
> - enum led_brightness brightness)
> + enum led_brightness brightness)

No need to touch it here as you also need (currently missed) update in the next
patch again.

With this being addressed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

--
With Best Regards,
Andy Shevchenko