Re: [PATCH] iio: gyro: adis16260: fix division by zero in write_raw

[Nuno Sá]

On Tue, Mar 31, 2026 at 01:13:00PM +0300, Antoniu Miclaus wrote:
> Add a validation check for the sampling frequency value before using it
> as a divisor. A user writing zero to the sampling_frequency sysfs
> attribute triggers a division by zero in the kernel.
> 
> Fixes: 089a41985c6c ("staging: iio: adis16260 digital gyro driver")
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> ---

Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>

>  drivers/iio/gyro/adis16260.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/gyro/adis16260.c b/drivers/iio/gyro/adis16260.c
> index 586e6cfa14a9..91b9c5f18ec4 100644
> --- a/drivers/iio/gyro/adis16260.c
> +++ b/drivers/iio/gyro/adis16260.c
> @@ -287,6 +287,9 @@ static int adis16260_write_raw(struct iio_dev *indio_dev,
>  		addr = adis16260_addresses[chan->scan_index][1];
>  		return adis_write_reg_16(adis, addr, val);
>  	case IIO_CHAN_INFO_SAMP_FREQ:
> +		if (val <= 0)
> +			return -EINVAL;
> +
>  		if (spi_get_device_id(adis->spi)->driver_data)
>  			t = 256 / val;
>  		else
> -- 
> 2.43.0
>