RE: [PATCH] ASoC: amd: ps: Fix missing leading zeros in subsystem_device SSID log

[Simon Trimmer]

> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Tuesday, March 31, 2026 12:27 PM
> To: Simon Trimmer <simont@xxxxxxxxxxxxxxxxxxxxx>
> Cc: linux-sound@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> patches@xxxxxxxxxxxxxxxxxxxxx; Vijendar.Mukunda@xxxxxxx
> Subject: Re: [PATCH] ASoC: amd: ps: Fix missing leading zeros in
> subsystem_device SSID log
> 
> On Tue, Mar 31, 2026 at 10:41:16AM +0000, Simon Trimmer wrote:
> > Ensure that subsystem_device is printed with leading zeros when combined
> > with subsystem_vendor to form the SSID. Without this, devices with upper
> > bits unset may appear to have an incorrect SSID in the debug output.
> 
> > Fixes: aab1301cfde344 ("ASoC: amd: ps: Propagate the PCI subsystem
> Vendor and Device IDs")
> 
> Fixes?
> 
> > -			dev_dbg(dev, "SSID %x%x\n", mach-
> >mach_params.subsystem_vendor,
> > +			dev_dbg(dev, "SSID %x%0x\n", mach-
> >mach_params.subsystem_vendor,
> 
> This doesn't specify a width so how would printk know how much to zero
> pad?

Hmm, that's a good point - I'll correct it

Looking at sound/ there's a handful of other log messages making this same
mistake