Re: [PATCH v8 4/7] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator

[Lee Jones]

On Tue, 31 Mar 2026, Lee Jones wrote:

> On Mon, 23 Mar 2026, Lakshay Piplani wrote:
> 
> > From: Aman Kumar Pandey <aman.kumarpandey@xxxxxxx>
> > 
> > Add core MFD support for the NXP P3H2x4x (P3H2440/P3H2441/P3H2840/P3H2841)
> > family of multiport I3C hub devices. These devices connect to a host via
> > I3C/I2C/SMBus and expose multiple downstream target ports.
> > 
> > Signed-off-by: Aman Kumar Pandey <aman.kumarpandey@xxxxxxx>
> > Signed-off-by: Vikash Bansal <vikash.bansal@xxxxxxx>
> > 
> > ---
> > Changes in v8:
> >  - No change
> > 
> > Changes in v7:
> >  - Use new config I3C_OR_I2C
> > 
> > Changes in v6:
> >  - No change
> > 
> > Changes in v5:
> >  - Corrected the ordering in the Makefile and Kconfig for MFD_P3H2X4X
> >  - Updated dev_err_probe() for regmap_init failure.
> >  - Updated module description
> > 
> > Changes in v4:
> >  - Split the driver into three separate patches(mfd, regulator and I3C hub)
> >  - Added support for NXP P3H2x4x MFD functionality
> > ---
> > ---
> >  MAINTAINERS                 |   2 +
> >  drivers/mfd/Kconfig         |  13 ++++
> >  drivers/mfd/Makefile        |   1 +
> >  drivers/mfd/p3h2840.c       | 125 ++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/p3h2840.h |  27 ++++++++
> >  5 files changed, 168 insertions(+)
> >  create mode 100644 drivers/mfd/p3h2840.c
> >  create mode 100644 include/linux/mfd/p3h2840.h

[...]

> > diff --git a/include/linux/mfd/p3h2840.h b/include/linux/mfd/p3h2840.h
> > new file mode 100644
> > index 000000000000..cba6fa516d1e
> > --- /dev/null
> > +++ b/include/linux/mfd/p3h2840.h
> > @@ -0,0 +1,27 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> 
> These should use // in header files.

Ignore this.  I've lead you astray there.

-- 
Lee Jones [李琼斯]