Re: [PATCH v3 4/4] drm/radeon: add WQ_PERCPU to alloc_workqueue users

[Alex Deucher]

Applied.  Thanks!

Alex

On Wed, Dec 24, 2025 at 10:26 AM Marco Crivellari
<marco.crivellari@xxxxxxxx> wrote:
>
> This continues the effort to refactor workqueue APIs, which began with
> the introduction of new workqueues and a new alloc_workqueue flag in:
>
>    commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
>    commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
>
> The refactoring is going to alter the default behavior of
> alloc_workqueue() to be unbound by default.
>
> With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
> any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
> must now use WQ_PERCPU. For more details see the Link tag below.
>
> In order to keep alloc_workqueue() behavior identical, explicitly request
> WQ_PERCPU.
>
> Suggested-by: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Marco Crivellari <marco.crivellari@xxxxxxxx>
> ---
>  drivers/gpu/drm/radeon/radeon_display.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 35fb99bcd9a7..99a3e4c480c1 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -685,7 +685,8 @@ static void radeon_crtc_init(struct drm_device *dev, int index)
>         if (radeon_crtc == NULL)
>                 return;
>
> -       radeon_crtc->flip_queue = alloc_workqueue("radeon-crtc", WQ_HIGHPRI, 0);
> +       radeon_crtc->flip_queue = alloc_workqueue("radeon-crtc",
> +                                                 WQ_HIGHPRI | WQ_PERCPU, 0);
>         if (!radeon_crtc->flip_queue) {
>                 kfree(radeon_crtc);
>                 return;
> --
> 2.52.0
>