Re: [PATCH] splice: prevent deadlock when splicing a file to itself

[Jens Axboe]

On 3/31/26 9:10 AM, Christoph Hellwig wrote:
> On Fri, Mar 20, 2026 at 06:36:15PM +0530, Deepanshu Kartikey wrote:
>> Fix this by checking if the input and output files share the
>> same inode before proceeding, returning -EINVAL if they do.
>> This mirrors the existing check in do_splice() for the
>> pipe-to-pipe case where ipipe == opipe.
> 
> While restricting splice to be between difference inodes sounds like a
> nice simplification, I'm not sure we can add it 20 years after the
> syscall was added.

Well if we could break splice all over with:

36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")

then surely this one would be OK too?

-- 
Jens Axboe