Re: [PATCH 3/8] mfd: omap-usb-host: Cleanup header includes
From: Lee Jones
Date: Tue Mar 31 2026 - 11:56:24 EST
On Mon, 23 Mar 2026, Thomas Richard wrote:
> Remove unused includes (linux/kernel.h, linux/types.h and linux/delay.h).
> Sort the remaining ones alphabetically.
What about 'linux/slab.h'?
> Signed-off-by: Thomas Richard <thomas.richard@xxxxxxxxxxx>
> ---
> drivers/mfd/omap-usb-host.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 4d29a6e2ed87abf2a0f6d5a704525baaa6f0cbcb..4e066a17cef0400edbfcb3012a16ceee06e52140 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -6,19 +6,15 @@
> * Author: Keshava Munegowda <keshava_mgowda@xxxxxx>
> * Author: Roger Quadros <rogerq@xxxxxx>
> */
> -#include <linux/kernel.h>
> -#include <linux/module.h>
> -#include <linux/types.h>
> -#include <linux/slab.h>
> -#include <linux/delay.h>
> #include <linux/clk.h>
> #include <linux/dma-mapping.h>
> -#include <linux/platform_device.h>
> +#include <linux/err.h>
> +#include <linux/module.h>
> #include <linux/platform_data/usb-omap.h>
> +#include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/of.h>
> #include <linux/of_platform.h>
This is still not alphabetical.
--
Lee Jones [李琼斯]