Re: [PATCH v4 3/3] ARM: dts: qcom: msm8960: expressatt: Add camera flash

[Rudraksha Gupta]

Hello Dmitry,

> > +	vreg_flash: regulator-flash {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "VREG_FLASH_3P3";
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		gpio = <&pm8921_mpps 4 GPIO_ACTIVE_HIGH>;
> > +		enable-active-high;
> > +		pinctrl-0 = <&flash_led_unlock>;
> > +		pinctrl-names = "default";
> > +	};
> > +
> > +	led-controller {
> It looks like the nodes are not sorted. Could you please make sure that
> they are sorted alphanumerically (if there is no node address)?

Thanks for your feedback! Could I request this comment/change be noted 
in 
https://lore.kernel.org/all/20260331-expressatt_fuel_guage-v1-1-23d1d8526b69@xxxxxxxxx/ 
instead? As this seems to be the only comment remaining, it will be 
easier for me to reorganize the DTS in the fuel gauge patch series 
rather than this one, as the fuel gauge patch series depends on this 
one. It also won't spam others in the mailing list who don't care about 
the reorganization of the DTS.


Thanks,

Rudraksha