Re: [PATCH] gpu: nova-core: bitfield: fix broken Default implementation

[John Hubbard]

On 3/31/26 6:36 AM, Danilo Krummrich wrote:
> On 3/31/26 9:56 AM, Eliot Courtney wrote:
>> The current implementation does not actually set the default values for
>> the fields in the bitfield. Set it and add a test.
>>
>> Signed-off-by: Eliot Courtney <ecourtney@xxxxxxxxxx>
> 
> Thanks for the fix!
> 
> Please add a Fixes: tag and separate the fix from the newly introduced Kunit test.
> 
> Maybe it is not worth adding the Kunit test in here as generic bitfields are
> being worked on, but I don't mind.
> 

If there is a chance that we won't need the Kunit test eventually,
then please either delete it here, or add a TODO to delete it
when generic bitfields cover this.

(Kunit, like any other test suite, is easy to add to, but also easy
to avoid pruning--and so over time it risks being full of tests
that are redundant or no longer needed.)

thanks,
-- 
John Hubbard