Re: [PATCH v1 1/1] selftests/cpu-hotplug: Make the script complaint with sh shell
From: Shuah Khan
Date: Tue Mar 31 2026 - 17:55:51 EST
On 3/18/26 02:08, Hubert Mazur wrote:
The script uses by default the bash shell that is inaccessible in
the x86 embedded devices. This leads to the syntax errors. To mitigate
some x86 embedded devices - which ones?
this, change the interpreter to /bin/sh and properly assign the
FUNCNAME variable for each of the functions as 'sh' doesn't set this
env. Change the conditional check for being a root from not
existent UID and replace with command execution "id -u".
Please include errors in the change log
Signed-off-by: Hubert Mazur <hmazur@xxxxxxxxxx>
---
tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
thanks,
-- Shuah