Re: [PATCH v1 2/2] riscv: dts: spacemit: add DeepComputing FML13V05 board device tree

[曹珊珊]

Hi Lan,

> From: "Yixun Lan"<dlan@xxxxxxxxxx>
> Hi Sandie, 
> 
> On 11:46 Tue 31 Mar     , Sandie Cao wrote:
> > From: sandiecao <sandie.cao@xxxxxxxxxxxxxxxx>
> > 
> > The FML13V05 board from DeepComputing incorporates a SpacemiT K3 RISC-V
> > SoC.It is a mainboard designed for the Framework Laptop 13 Chassis,
> > which has (Framework) SKU FRANHQ0001.
> > 
> > The FML13V05 board features:
> > - SpacemiT K3 RISC-V SoC
> > - LPDDR5 16GB or 32GB
> > - eMMC 32GB ~128GB (Optional)
> > - UFS 3.1 256G (Optional)
> > - QSPI Flash
> > - MicroSD Slot
> > - PCIe-based Wi-Fi
> > - 4 USB-C Ports
> >  - Port 1: PD 3.0 (65W Max), USB 3.2 Gen 1
> >  - Port 2: PD 3.0 (65W Max), USB 3.2 Gen 1, DP 1.4 (4K@60Hz)
> >  - Port 3 & 4: USB 3.2 Gen 1
> > 
> > This minimal device tree enables booting into a serial console with UART
> > output.
> > 
> > Signed-off-by: sandiecao <sandie.cao@xxxxxxxxxxxxxxxx>
> > Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@xxxxxxxxxxxxx>
> should put your own signed-off at the end.
> 
> > ---
> >  arch/riscv/boot/dts/spacemit/Makefile         |  1 +
> >  .../spacemit/k3-deepcomputing-fml13v05.dts    | 28 +++++++++++++++++++
> >  2 files changed, 29 insertions(+)
> >  create mode 100644 arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> > 
> > diff --git a/arch/riscv/boot/dts/spacemit/Makefile b/arch/riscv/boot/dts/spacemit/Makefile
> > index 7e2b87702571..acb993c452ba 100644
> > --- a/arch/riscv/boot/dts/spacemit/Makefile
> > +++ b/arch/riscv/boot/dts/spacemit/Makefile
> > @@ -4,4 +4,5 @@ dtb-$(CONFIG_ARCH_SPACEMIT) += k1-milkv-jupiter.dtb
> >  dtb-$(CONFIG_ARCH_SPACEMIT) += k1-musepi-pro.dtb
> >  dtb-$(CONFIG_ARCH_SPACEMIT) += k1-orangepi-r2s.dtb
> >  dtb-$(CONFIG_ARCH_SPACEMIT) += k1-orangepi-rv2.dtb
> > +dtb-$(CONFIG_ARCH_SPACEMIT) += k3-deepcomputing-fml13v05.dtb
> >  dtb-$(CONFIG_ARCH_SPACEMIT) += k3-pico-itx.dtb
> > diff --git a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> > new file mode 100644
> > index 000000000000..2343ae3acc2d
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> > @@ -0,0 +1,28 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +/*
> > + * Copyright (C) 2024 DeepComputing (HK) Limited
> should cover current year, which is 2026 now..
> 
> > + */
> > +
> > +#include "k3.dtsi"
> > +
> > +/ {
> > +        model = "DeepComputing FML13V05";
> > +        compatible = "deepcomputing,fml13v05", "spacemit,k3";
> > +
> > +        aliases {
> > +                serial0 = &uart0;
> > +        };
> > +
> > +        chosen {
> > +                stdout-path = "serial0";
> > +        };
> > +
> > +        memory@100000000 {
> > +                device_type = "memory";
> > +                reg = <0x1 0x00000000 0x4 0x00000000>;
> > +        };
> > +};
> > +
> > +&uart0 {
> Can you also add pinctrl data explicitly?

To avoid conflict,  the common pinctrl table "k3-pinctrl.dtsi" should be uploaded by spacemit. 
Then we will add the pinctrl data after k3-pico-itx.dts. That should be another patch. 
Sandie

> 
> > +        status = "okay";
> > +};
> > -- 
> > 2.43.0
> 
> -- 
> Yixun Lan (dlan)
>