Re: [PATCH] arm64: dts: imx8x-colibri: Correct SODIMM PAD settings

[Daniel Baluta]

On 4/1/26 09:40, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>
> SION is BIT(30), not BIT(26). Correct it.
>
> Fixes: 7ece3cbc8b1ef ("arm64: dts: colibri-imx8x: Add atmel pinctrl groups")
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxx>

What is the general attitude around using symbolic macros for pin config?
Like here: https://www.spinics.net/lists/kernel/msg6072866.html

I think there are useful to avoid this kind of bugs.

If I get enough Ack's I can move forward and replace all magic numbers from imx dtses.

thanks,

Daniel