RE: [Intel-wired-lan] [PATCH iwl-next v1 1/2] igb: use napi_schedule_irqoff() instead of napi_schedule()

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf
> Of Daiki Harada
> Sent: Tuesday, March 31, 2026 12:39 PM
> To: intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn
> <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; Daiki Harada <daiky0325@xxxxxxxxx>; Kohei
> Enju <kohei@xxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1 1/2] igb: use
> napi_schedule_irqoff() instead of napi_schedule()
> 
> Replace napi_schedule() with napi_schedule_irqoff() in the interrupt
> handler path in igb driver
> 
> Tested on QEMU with igb NIC emulation (-nic user,model=igb)
> 
> Suggested-by: Kohei Enju <kohei@xxxxxxxx>
> Signed-off-by: Daiki Harada <daiky0325@xxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
> b/drivers/net/ethernet/intel/igb/igb_main.c
> index ee99fd8fd513..d7a6ae938cc5 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -7158,7 +7158,7 @@ static irqreturn_t igb_msix_ring(int irq, void
> *data)
>  	/* Write the ITR value calculated from the previous interrupt.
> */
>  	igb_write_itr(q_vector);
> 
> -	napi_schedule(&q_vector->napi);
> +	napi_schedule_irqoff(&q_vector->napi);
> 
>  	return IRQ_HANDLED;
>  }
> @@ -8199,7 +8199,7 @@ static irqreturn_t igb_intr_msi(int irq, void
> *data)
>  	if (icr & E1000_ICR_TS)
>  		igb_tsync_interrupt(adapter);
> 
> -	napi_schedule(&q_vector->napi);
> +	napi_schedule_irqoff(&q_vector->napi);
> 
>  	return IRQ_HANDLED;
>  }
> @@ -8245,7 +8245,7 @@ static irqreturn_t igb_intr(int irq, void *data)
>  	if (icr & E1000_ICR_TS)
>  		igb_tsync_interrupt(adapter);
> 
> -	napi_schedule(&q_vector->napi);
> +	napi_schedule_irqoff(&q_vector->napi);
> 
>  	return IRQ_HANDLED;
>  }
> --
> 2.53.0


Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>