Re: [PATCH] arch/sh: Drop CONFIG_FIRMWARE_EDID from defconfig files

[John Paul Adrian Glaubitz]

Hi Thomas,

On Wed, 2026-04-01 at 10:32 +0200, Thomas Zimmermann wrote:
> CONFIG_FIRMWARE_EDID=y depends on X86 or EFI_GENERIC_STUB. Neither is
> true here, so drop the lines from the defconfig files.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> ---
>  arch/sh/configs/dreamcast_defconfig | 1 -
>  arch/sh/configs/hp6xx_defconfig     | 1 -
>  arch/sh/configs/se7343_defconfig    | 1 -
>  arch/sh/configs/se7780_defconfig    | 1 -
>  4 files changed, 4 deletions(-)
> 
> diff --git a/arch/sh/configs/dreamcast_defconfig b/arch/sh/configs/dreamcast_defconfig
> index dd58797e8298..b31bf17fe112 100644
> --- a/arch/sh/configs/dreamcast_defconfig
> +++ b/arch/sh/configs/dreamcast_defconfig
> @@ -50,7 +50,6 @@ CONFIG_HW_RANDOM=y
>  CONFIG_WATCHDOG=y
>  CONFIG_SH_WDT=y
>  CONFIG_FB=y
> -CONFIG_FIRMWARE_EDID=y
>  CONFIG_FB_PVR2=y
>  CONFIG_FRAMEBUFFER_CONSOLE=y
>  CONFIG_FONTS=y
> diff --git a/arch/sh/configs/hp6xx_defconfig b/arch/sh/configs/hp6xx_defconfig
> index 04a9fcb4342a..b6116a203a27 100644
> --- a/arch/sh/configs/hp6xx_defconfig
> +++ b/arch/sh/configs/hp6xx_defconfig
> @@ -35,7 +35,6 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y
>  CONFIG_LEGACY_PTY_COUNT=64
>  # CONFIG_HWMON is not set
>  CONFIG_FB=y
> -CONFIG_FIRMWARE_EDID=y
>  CONFIG_FB_HIT=y
>  CONFIG_FB_SH_MOBILE_LCDC=y
>  CONFIG_FRAMEBUFFER_CONSOLE=y
> diff --git a/arch/sh/configs/se7343_defconfig b/arch/sh/configs/se7343_defconfig
> index 2d4d1f974f14..b3ce8a502787 100644
> --- a/arch/sh/configs/se7343_defconfig
> +++ b/arch/sh/configs/se7343_defconfig
> @@ -57,7 +57,6 @@ CONFIG_I2C=y
>  CONFIG_I2C_SH_MOBILE=y
>  # CONFIG_HWMON is not set
>  CONFIG_FB=y
> -CONFIG_FIRMWARE_EDID=y
>  CONFIG_FB_SH_MOBILE_LCDC=m
>  CONFIG_SOUND=y
>  CONFIG_SND=y
> diff --git a/arch/sh/configs/se7780_defconfig b/arch/sh/configs/se7780_defconfig
> index 13fa6a59b8f1..9e96b000cb99 100644
> --- a/arch/sh/configs/se7780_defconfig
> +++ b/arch/sh/configs/se7780_defconfig
> @@ -60,7 +60,6 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y
>  # CONFIG_HW_RANDOM is not set
>  CONFIG_THERMAL=y
>  CONFIG_FB=y
> -CONFIG_FIRMWARE_EDID=y
>  CONFIG_FB_SH_MOBILE_LCDC=m
>  CONFIG_FRAMEBUFFER_CONSOLE=y
>  CONFIG_LOGO=y

Thanks for catching this! I wonder where this configuration entry comes from though.

My SH7785LCR board does have a DVI output as well as a Silicon Motion SM-501 video
chip though, so I think it should be able to perform EDID in general. Or is the
protocol actually tied to the x86 architecture? What about monitors on a PowerPC
workstation, for example? Does EDID not work there at all?

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913