Re: [PATCH v2 2/2] staging: octeon: ethernet: replace pr_* with dev_* and netdev_*
From: Dan Carpenter
Date: Wed Apr 01 2026 - 05:46:42 EST
On Tue, Mar 31, 2026 at 04:47:57PM +0530, AyushMukkanwar wrote:
> @@ -783,16 +797,15 @@ static int cvm_oct_probe(struct platform_device *pdev)
> dev->max_mtu = OCTEON_MAX_MTU - mtu_overhead;
>
> if (register_netdev(dev) < 0) {
> - pr_err("Failed to register ethernet device for POW\n");
> + netdev_err(dev, "Failed to register ethernet device for POW\n");
> free_netdev(dev);
> } else {
> cvm_oct_device[CVMX_PIP_NUM_INPUT_PORTS] = dev;
> - pr_info("%s: POW send group %d, receive group %d\n",
> - dev->name, pow_send_group,
> - pow_receive_group);
> + netdev_info(dev, "POW send group %d, receive group %d\n",
> + pow_send_group, pow_receive_group);
> }
Please run your patches through checkpatch.pl.
regards,
dan carpenter