Re: [PATCH 0/5] rtw_sdio_if1_init cleanup and small logic tweak

[Luka Gejak]

On April 1, 2026 10:29:37 AM GMT+02:00, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>On Tue, Mar 31, 2026 at 10:25:22PM +0200, Luka Gejak wrote:
>> Hi Omer,
>> Thank you for submitting this patch series. Efforts to clean up the 
>> initialization paths in these legacy Realtek staging drivers are 
>> always welcome, as they are a necessary step toward aligning the code 
>> with upstream kernel standards and eventually moving the driver out of
>> staging.
>> I have performed a detailed technical audit of the series. While the 
>
><snip>
>
>Luka, this review REALLY looks like it was AI generated, and then
>cut-pasted into here.  Please do not do that.
>
>If you wish to use AI to generate reviews, great, then use some of the
>tools we already have, and notify the submitter that this is an AI
>report and that it should be treated as such.  Don't try to pass it off
>as a human review that must actually be trusted.
>
>thanks,
>
>greg k-h

Hi Greg,
You're right, I used a tool to help format the response because 
English is not my native language and I wanted the review to be clear.
I see now that it made the response look like a bot report and I 
apologize for that. I'll stick to writing reviews manually going 
forward. However the technical issues I pointed out (like the inverted
_SUCCESS/_FAIL logic in the staging headers and the uninitialized 
pnetdev pointer) are real regressions I found while auditing the code 
on my local tree. I'll make sure future feedback is direct and clearly
identified if I use any tooling.
Thanks for the correction.
Best regards,
Luka Gejak