Re: [PATCH 2/4] platform: arm64: dell-xps-ec: new driver

[Ilpo Järvinen]

On Wed, 1 Apr 2026, Konrad Dybcio wrote:

> On 4/1/26 9:33 AM, Aleksandrs Vinarskis wrote:
> > Introduce EC driver for Dell XPS 13 9345 (codename 'tributo') which may
> > partially of fully compatible with Snapdragon-based Dell Latitude,
> > Inspiron ('thena'). Primary function of this driver is unblock EC's
> > thermal management, specifically to provide it with necessary
> > information to control device fans, peripherals power.
> 
> [...]
> 
> > +/*
> > + * Format:
> > + * - header/unknown (2 bytes)
> > + * - per-thermistor entries (3 bytes): thermistor_id, param1, param2
> > + */
> > +static const u8 dell_xps_ec_thermistor_profile[] = {
> > +	0xff, 0x54,
> 
> This is super wishful thinking, but 0x54 is ASCII 'T', perhaps for
> "Thermistor" or "Temp"?
> 
> > +static int dell_xps_ec_suspend_cmd(struct dell_xps_ec *ec, bool suspend)
> > +{
> > +	u8 buf[DELL_XPS_EC_SUSPEND_MSG_LEN] = {};
> > +	int ret;
> > +
> > +	buf[0] = DELL_XPS_EC_SUSPEND_CMD;
> > +	buf[1] = suspend ? 0x01 : 0x00;
> > +	/* bytes 2..63 remain zero */
> 
> buf[1] = suspend
> 
> (since it's a boolean argument)

I'd prefer boolean -> binary conversion is done explicitly.

-- 
 i.