Re: [PATCH 0/5] rtw_sdio_if1_init cleanup and small logic tweak

From: Luka Gejak

Date: Wed Apr 01 2026 - 07:03:51 EST


On April 1, 2026 12:29:52 PM GMT+02:00, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>On Wed, Apr 01, 2026 at 12:17:41PM +0200, Luka Gejak wrote:
>> Hi Omer,
>> Thank you for submitting this patch series. I like the idea, however
>> during my review I have found that there are several issues.
>
><snip>
>
>Please review things "inline" like a human does. With the code in
>place, and the comments right below the code.
>
>As you are using AI for this, PLEASE use an AI tool that actually works.
>Use the ones that we have public, which DOES get this right and puts the
>review comments in the correct places, and in the correct format.
>
>If I were confronted with a review like this on patch 0/X, it would be
>very hard for me to actually digest and handle it, given that the
>context is not there at all.
>
>I suggest you take some time off, work on your review workflow, and
>then, if you still want to help out with reviews, do it in the proper
>way that we all have been doing for decades.
>
>thanks,
>
>greg k-h

Hi Greg,
Thank you for the guidance. I understand now why the summary-style
review is difficult to process. I will take your advice, step back,
and fix my workflow.
Best regards,
Luka Gejak