Re: [PATCH v6 5/5] x86/CPU/AMD: Print AGESA string from DMI additional information entry
From: Borislav Petkov
Date: Wed Apr 01 2026 - 07:56:07 EST
On Wed, Apr 01, 2026 at 12:29:08PM +0200, Borislav Petkov wrote:
> On Wed, Apr 01, 2026 at 11:17:01AM +0200, Jean Delvare wrote:
> > Isn't "V9" going to become "V10" at some point in the future, and then
> > the AGESA string will no longer be displayed until the code is
> > adjusted? Or will AMD move the information to a more appropriate place
> > by then?
> >
> > Also, I know this was discussed before, but the current print strategy
> > omits "V9". Is this not something we are going to regret once more
> > versions are available and we may have to differentiate between them?
>
> Right, I think we should not be silly and simply dump the string that starts
> with "AGESA" and that's it.
IOW, this:
if (!strncmp(string_ptr, "AGESA", 5)) {
pr_info("AGESA: %s\n", string_ptr);
break;
}
Mario, what's that additional "dance" you're doing there? Do we have other
strings which start with "AGESA"?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette